Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/krpc-data-stream-sender.h@271 PS1, Line 271: /// Memory tracker from Parent Memory Tracker for tracking memory of OutBoundRowBatch serialization line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/krpc-data-stream-sender.cc@782 PS1, Line 782: outbound_rb_mem_tracker_.reset(new MemTracker(-1, "Memory tracker for OutBoundRowBatch serialization", parent_mem_tracker, false)); line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/krpc-data-stream-sender.cc@1108 PS1, Line 1108: RETURN_IF_ERROR(src->Serialize(dest, outbound_rb_free_pool_.get(), krpc_tuple_data_bytes_, krpc_compression_scratch_bytes_)); line too long (129 > 90) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/row-batch.h@108 PS1, Line 108: pool->Free(const_cast<uint8_t*>(reinterpret_cast<const uint8_t*>(compression_scratch_))); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/row-batch.cc@414 PS1, Line 414: RETURN_IF_ERROR(SerializeInternal(size, &distinct_tuples, tuple_offsets, tuple_data_ptr)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/18798/1/be/src/runtime/row-batch.cc@519 PS1, Line 519: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 1 Gerrit-Owner: Omid Shahidi <omid.shahidi.2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Jul 2022 22:09:34 +0000 Gerrit-HasComments: Yes
