Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 10: Code-Review+1 (1 comment) The patch LGTM. I just have a minor comment. I can bump to +2 if other reviewers have no comments. Thanks! http://gerrit.cloudera.org:8080/#/c/18729/10/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/10/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@211 PS10, Line 211: ensureCreateKuduTableParamsValid nit: "validateCreateKuduTableParams" sounds better -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 10 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Sun, 31 Jul 2022 08:40:56 +0000 Gerrit-HasComments: Yes
