Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18736 )
Change subject: IMPALA-10918: Allow map type in SELECT list ...................................................................... Patch Set 8: Code-Review+1 (4 comments) lgtm, only nits http://gerrit.cloudera.org:8080/#/c/18736/8/be/src/runtime/raw-value.h File be/src/runtime/raw-value.h: http://gerrit.cloudera.org:8080/#/c/18736/8/be/src/runtime/raw-value.h@71 PS8, Line 71: array Now it can be also a map http://gerrit.cloudera.org:8080/#/c/18736/8/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/18736/8/be/src/runtime/raw-value.cc@424 PS8, Line 424: item->GetCollectionSlot(slot_desc.tuple_offset()); +2 indentation http://gerrit.cloudera.org:8080/#/c/18736/8/be/src/runtime/raw-value.cc@427 PS8, Line 427: slot_desc.children_tuple_descriptor(); +2 indentation http://gerrit.cloudera.org:8080/#/c/18736/8/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18736/8/tests/query_test/test_nested_types.py@204 PS8, Line 204: cls.ImpalaTestMatrix.add_dimension( : ImpalaTestDimension('mt_dop', 0, 2)) : cls.ImpalaTestMatrix.add_dimension( : create_exec_option_dimension_from_dict({ nit: even more indentation :) -- To view, visit http://gerrit.cloudera.org:8080/18736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I921c647f1779add36e7f5df4ce6ca237dcfaf001 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Aug 2022 16:05:44 +0000 Gerrit-HasComments: Yes
