Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 )
Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18688/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18688/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5533 PS5, Line 5533: private void alterTableExecute(Table tbl, TAlterTableExecuteParams params) { : FeIcebergTable iceTbl = (FeIcebergTable)tbl; : ExpireSnapshots expireApi = iceTbl.getIcebergApiTable().expireSnapshots(); : expireApi.expireOlderThan(params.older_than_millis); : expireApi.commit(); : } This method could be moved to IcebergCatalogOpExecutor. http://gerrit.cloudera.org:8080/#/c/18688/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18688/5/tests/query_test/test_iceberg.py@68 PS5, Line 68: # We are setting the TIMEZONE query option in this test, so let's create a local : # impala client. We are not setting the timezone in this test. -- To view, visit http://gerrit.cloudera.org:8080/18688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideffee4964c18c85ca745bfb4eca08ec362416f3 Gerrit-Change-Number: 18688 Gerrit-PatchSet: 5 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Aug 2022 16:19:10 +0000 Gerrit-HasComments: Yes
