Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18802 )
Change subject: IMPALA-11474: Codegen Tuple size in sorter-ir.cc ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18802/5/be/src/exec/partial-sort-node.cc File be/src/exec/partial-sort-node.cc: http://gerrit.cloudera.org:8080/#/c/18802/5/be/src/exec/partial-sort-node.cc@98 PS5, Line 98: children_[0]->row_descriptor_->tuple_descriptors()[0]->byte_size() Looked at this after seeing that the tests failed in Kudu inserts (which uses partial sort) This doesn't look right to me, as the child's tuple size can be different than the materialized sort tuple size. The child can also have multiple tuples. We should use row_descriptor_'s tuple size similarly to SortNode. -- To view, visit http://gerrit.cloudera.org:8080/18802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4161a61db1782dc448dae9a1d4c1d120b055b3c Gerrit-Change-Number: 18802 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Fri, 05 Aug 2022 07:13:44 +0000 Gerrit-HasComments: Yes
