Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18781 )
Change subject: IMPALA-11456: Collapse filesystem Skip logic ...................................................................... Patch Set 5: Code-Review+1 (3 comments) Thanks for cleaning this up, it was very frustrating to copy-paste these things around! http://gerrit.cloudera.org:8080/#/c/18781/5/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/18781/5/tests/common/skip.py@31 PS5, Line 31: nit, here and at other place: in we Impala 4 space indentation is used on line breaks, even in Python http://gerrit.cloudera.org:8080/#/c/18781/5/tests/common/skip.py@48 PS5, Line 48: caching Probably it is a good time to change this to hdfs_caching? just caching is ambiguous IMO, as we also use remote data caching http://gerrit.cloudera.org:8080/#/c/18781/5/tests/common/skip.py@71 PS5, Line 71: # These need test infra work to re-enable. hive could be moved to this section from line 49, as it supports s3 AFAIK -- To view, visit http://gerrit.cloudera.org:8080/18781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib928a6274baaaec45614887b9e762346a25812a1 Gerrit-Change-Number: 18781 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 06 Aug 2022 11:13:58 +0000 Gerrit-HasComments: Yes
