Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18821 )
Change subject: IMPALA-11480: Retain all YARN container logs in a Jenkins run ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > (1 comment) Thanks for the comment Quanlong! I have slightly changed my previous patch according to your suggestion. http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py: http://gerrit.cloudera.org:8080/#/c/18821/1/testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py@59 PS1, Line 59: 86400, > Should we use numbers instead of strings, i.e. 86400 instead of '86400'? I Thanks Quanlong! Yes. In order to be consistent, I will change '86400' to 86400 (It looks like '86400' works as well) in the next patch set. -- To view, visit http://gerrit.cloudera.org:8080/18821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10953f5de98d4312dfc563fcace17908c86be2d3 Gerrit-Change-Number: 18821 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal (Cloudera) <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Mon, 08 Aug 2022 18:57:17 +0000 Gerrit-HasComments: Yes
