Michael Smith has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18828


Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests
......................................................................

IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests

Use lazy initialization for TMP_DIR_PREFIX_LIST so not all tests have to
create a BackendConfig. Some tests do using FeSupport.loadLibrary, and
the new tests for FileSystemUtil required initializing
BackendConfig.INSTANCE.

Failure to initialize BackendConfig meant that test success would depend
on their order. If FileSystemUtilTest or another test that initialized
it were the first to use FileSystemUtil, then everything would pass. If
not, the static declaration in FileSystemUtil would fail, causing the
class to fail to be loaded. Later tests would fail with NoClassDefFound
errors.

Adds initialization to FileMetadataLoaderTest as it has explicit hidden
file tests. Any tests that test hidden file functionality must ensure
BackendConfig is loaded so TMP_DIR_PREFIX_LIST is correctly initialized.
Without that, hidden file filtering will not work correctly.

Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
2 files changed, 27 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18828/1
--
To view, visit http://gerrit.cloudera.org:8080/18828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f
Gerrit-Change-Number: 18828
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>

Reply via email to