Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: The only select constant statement need not to spool results ...................................................................... Patch Set 4: (1 comment) This makes sense to me. I think we can further optimize this to disable result spooling on some other simple queries, e.g. "select uuid()". It's ok to do it in a follow-up JIRA. There is a line in profile for "Query Options (set by configuration and planner)". When the planner turns off result spooling, will "SPOOL_QUERY_RESULTS=false" appear there? http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@475 PS4, Line 475: enable result spooling nit: "result spooling is enabled" -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 4 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Aug 2022 08:18:17 +0000 Gerrit-HasComments: Yes
