Omid Shahidi has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 7: (5 comments) > Patch Set 7: > > (4 comments) http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/benchmarks/row-batch-serialize-benchmark.cc File be/src/benchmarks/row-batch-serialize-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/benchmarks/row-batch-serialize-benchmark.cc@38 PS7, Line 38: : // Benchmark to measure how quickly we can serialize and deserialize row batches. More : // specifically, this benchmark was developed to measure the overhead of deduplication. : // The benchmarks are divided into serialization and deserialization benchmarks. : // The serialization benchmarks test different serialization methods (the new default of : // adjacent deduplication vs. the baseline of no deduplication) on row batches with : // different patterns of duplication: no_dups and adjacent_dups. : // For all benchmarks we use (int, string) tuples to exercise both variable-length and : // fixed-length slot handling. The small tuples with few slots emphasizes per-tuple : // dedup performance rather than per-slot serialization/deserialization performance. : // : // serialize: Function Rate (iters/ms) Comparison : // ---------------------------------------------------------------------- : // ser_no_dups_baseline 17.43 1X : // ser_no_dups 17.33 0.9944X : // ser_no_dups_full 14.1 0.8092X : // : // ser_adjacent_dups_baseline 26.65 1X : // ser_adjacent_dups 63.98 2.4X : // ser_adjacent_dups_full 55.88 2.096X : // : // ser_dups_baseline 19.26 1X : // ser_dups 19.55 1.015X : // ser_dups_full 32.4 1.682X : // : // deserialize: Function Rate (iters/ms) Comparison : // ---------------------------------------------------------------------- : // deser_no_dups_baseline 64.94 1X : // deser_no_dups 69.24 1.066X : // : // deser_adjacent_dups_baseline 112 1X : // deser_adjacent_dups 207.4 1.852X : // : // deser_dups_baseline 114.8 1X : // deser_dups 208.5 1.817X : // : // Earlier results with LossyHashTable : // serialize: Function Rate (iters/ms) Comparison : // ---------------------------------------------------------------------- : // ser_no_dups_lossy 15.93 0.9139X : // ser_adjacent_dups_lossy 58.21 2.184X : // ser_dups_lossy 50.46 2.62X : // : // Earlier results with boost::unordered_map : // serialize: Function Rate (iters/ms) Comparison : // ---------------------------------------------------------------------- : // ser_no_dups_full 8.73 0.5582X : // : // ser_adjacent_dups_full 38.7 1.634X : // : // ser_dups_full 27.5 1.54X Should this be removed and updated with the current benchmark scores? http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h File be/src/runtime/row-batch.inline.h: http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h@22 PS7, Line 22: > extra line Done http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h@34 PS7, Line 34: for_compression > These three lines check for_compression, you can change code as: Done http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test File testdata/workloads/tpch/queries/datastream-sender.test: http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test@1 PS7, Line 1: ==== > This file should be put in testdata/workloads/functional-query/queries Created a query for functional-query workload and a query for tpch workload in their respective directories http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test@49 PS7, Line 49: > extra space Done -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 7 Gerrit-Owner: Omid Shahidi <omid.shahidi.2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Omid Shahidi <omid.shahidi.2...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Aug 2022 01:14:25 +0000 Gerrit-HasComments: Yes
