Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 )
Change subject: IMPALA-11429: Set table owner after creating an Iceberg table ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3633 PS5, Line 3633: throw new ImpalaRuntimeException("Failed to set table owner after creating " + : "Iceberg table but the table has been created successfully", e); > I was thinking about a rollback, which is probably a drop table in this cas Rollback would in fact be a good choice here but I don't think I should implement that at this point for the following reasons: - If the ALTER TABLE part fails then we are where we were without this patch so actually we haven't made made anything worse, but with the ALTER TABLE part succeeding we get to the state we wanted to. - This ALTER TABLE step is a temporary one until we manage to enhance the Iceberg API to also accept a table owner during table creation. - Adding one more step would result a CREATE TABLE as a 3 step operation in some use cases and I feel that over complicated and too error prone. - If the "automatic" ALTER TABLE fails there is still the opportunity to run a manual ALTER TABLE with a user with enough permissions to fix the table. http://gerrit.cloudera.org:8080/#/c/18837/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18837/5/tests/query_test/test_iceberg.py@130 PS5, Line 130: loading fails > Thank you for explaining. Could you add this Jira to the above comment as w Done -- To view, visit http://gerrit.cloudera.org:8080/18837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cac198a4a53be3599cb582864ee5f8c269202c0 Gerrit-Change-Number: 18837 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Tue, 23 Aug 2022 08:47:08 +0000 Gerrit-HasComments: Yes