Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/18898 )
Change subject: IMPALA-11496: Push down date literals to Kudu scanner ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18898/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18898/2//COMMIT_MSG@11 PS2, Line 11: added for DATE, BIGINT, FLOAT, DOUBLE types to > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@571 PS2, Line 571: kuduPredicate = KuduPredicate.newComparisonPredicate(column, op, > line too long (108 > 90) Done http://gerrit.cloudera.org:8080/#/c/18898/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@580 PS2, Line 580: //All supported types are covered > We generally use Preconditions.checkState(false) Done -- To view, visit http://gerrit.cloudera.org:8080/18898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f323d23df3a92361390f9da387182db3f3bde3e Gerrit-Change-Number: 18898 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Aug 2022 12:59:59 +0000 Gerrit-HasComments: Yes
