Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18918 )
Change subject: IMPALA-11226: Add script to simplify resolving minidumps ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks good to me. http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py File bin/resolve_minidumps.py: http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py@149 PS1, Line 149: logging.error("Could not determine breakpad version from toolchain") return None if breakpad_version is None? http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py@181 PS1, Line 181: dump_syms Should we check if dump_syms is None since find_breakpad_binary() could return None? -- To view, visit http://gerrit.cloudera.org:8080/18918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f8fdcb8ca89d0904dc8ec69337e3d5dfdd54adf Gerrit-Change-Number: 18918 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sat, 27 Aug 2022 11:37:36 +0000 Gerrit-HasComments: Yes
