Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 )
Change subject: IMPALA-10214: Ozone remote file handle caching ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG@10 PS5, Line 10: Updates : file handle cache enablement to be more stringent about enabling : caching, similar to what's suggested in IMPALA-10375. Nit: I think this addresses IMPALA-10375, so we can modify the language here to say that this resolves IMPALA-10375. I assume we'll close IMPALA-10375 when this goes in. You can include IMPALA-10375 as another JIRA in the title if you want. http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py@182 PS5, Line 182: --max_cached_file_handles=0 If max_cached_file_handles=0, caching can't happen (is_file_handle_caching_enabled() is false) and none of the other flags matter. One option for a test would be to keep max_cached_file_handles non-zero, but then specify all the cache_X_file_handles=false. That would verify that those flags function. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Aug 2022 19:42:02 +0000 Gerrit-HasComments: Yes
