Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18927 )

Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive 
function.
......................................................................


Patch Set 2:

(2 comments)

The build failure looks related:
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17408/testReport/junit/custom_cluster.test_permanent_udfs/TestUdfPersistence/test_corrupt_java_bad_function/

http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
File java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java:

http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java@25
PS2, Line 25: We import the class NumberParseException from
            :  * Google's phone number library that won't be shaded with the 
UDF jar
Where do we import it? CorruptUdf seems a valid udf to me at the first glance.


http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py
File tests/custom_cluster/test_permanent_udfs.py:

http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py@183
PS2, Line 183: funcction
typo



--
To view, visit http://gerrit.cloudera.org:8080/18927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Gerrit-Change-Number: 18927
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <scar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 04:18:48 +0000
Gerrit-HasComments: Yes

Reply via email to