Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/15/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@222 PS15, Line 222: srcTable > Do we need to check the target table as well? Could you add a test in this If srcTable is kudu type, the target table is also kudu type. The previous if statement judged. I added this test in https://gerrit.cloudera.org/#/c/18729/17/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 15 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Tue, 06 Sep 2022 02:55:54 +0000 Gerrit-HasComments: Yes
