Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas ...................................................................... Patch Set 1: (2 comments) Thank you for the review Csaba, updated the change. http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1118 PS1, Line 1118: Impyla handle > Do you know what kind of other handles can we see here? Yes, it is a QueryHandle object described in thrift returned by the BeeswaxService thrift service: https://github.com/apache/impala/blob/master/common/thrift/beeswax.thrift#L127 http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1122 PS1, Line 1122: if isinstance(handle.get_handle(), HiveServer2Cursor): : timeout_msg = timeout_msg.format(handle.get_handle()._last_operation_string, : expected_states, actual_state) : else: : timeout_msg = timeout_msg.format(handle.get_handle().id, expected_states, : actual_state) > Can you put this logic somehow in a separate function? e.g. get_id_or_query Done -- To view, visit http://gerrit.cloudera.org:8080/18933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d Gerrit-Change-Number: 18933 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 08:18:06 +0000 Gerrit-HasComments: Yes
