Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18863 )
Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query ...................................................................... Patch Set 8: Code-Review+1 (2 comments) +1, please add the comment in InlineViewRef. Let's wait for @csringhofer for +2. http://gerrit.cloudera.org:8080/#/c/18863/7/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/18863/7/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@454 PS7, Line 454: Set > Complex type fields can be added twice as they are part of the select state Can you put that into a comment here? http://gerrit.cloudera.org:8080/#/c/18863/7/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18863/7/tests/query_test/test_nested_types.py@897 PS7, Line 897: # > Method level comments converted to simple comments, only the class level co Ok, this is good too. -- To view, visit http://gerrit.cloudera.org:8080/18863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84b5e5703f9e0ce0f4f8bff83941677dd7489974 Gerrit-Change-Number: 18863 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 07:51:11 +0000 Gerrit-HasComments: Yes
