Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18929 )
Change subject: IMPALA-11539: Mitigate intra-node skew of file scans with MT_DOP ...................................................................... Patch Set 8: (1 comment) Good to see you again, Qifan! Thanks for the suggestions, probably it would be the best to track these ideas in Jira. I fixed a test error in the latest patch. http://gerrit.cloudera.org:8080/#/c/18929/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18929/3/tests/query_test/test_scanners.py@378 PS3, Line 378: 'text')) > It is ok like this, maybe we can look into it deeper if the test turn out t Sorry I had a test error as the tests used a text table from my local database. Parquet scanning is still improved by this test but I get different ratios and higher variance, so I'm limiting the test to 'text' to make it more stable, as you originally suggested. -- To view, visit http://gerrit.cloudera.org:8080/18929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7dc1f1665565da6c0e155c1e585f7089b18a180 Gerrit-Change-Number: 18929 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Sep 2022 10:51:52 +0000 Gerrit-HasComments: Yes
