Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18970 )

Change subject: IMPALA-11572: deflake test_mt_dop_skew_lpt
......................................................................


Patch Set 1:

(3 comments)

Thanks for the comments.

http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py@401
PS1, Line 401: se
> typo
Done


http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py@405
PS1, Line 405: +
> flake8: E226 missing whitespace around arithmetic operator
Done


http://gerrit.cloudera.org:8080/#/c/18970/1/tests/query_test/test_scanners.py@410
PS1, Line 410:         print "Intra-node bytes read ratio:", ratio
> Is this intentionally left here?
Yeah, I also mentioned it in the commit message. So if the test fails we'll 
know what were the ratios.



--
To view, visit http://gerrit.cloudera.org:8080/18970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I823542c21fe8f10f43a501fe4175da883eaf2f99
Gerrit-Change-Number: 18970
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 15:12:34 +0000
Gerrit-HasComments: Yes

Reply via email to