Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 )
Change subject: IMPALA-9999: Switch to GCC 10.4 ...................................................................... Patch Set 14: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18134/14/be/src/udf/udf.cc File be/src/udf/udf.cc: http://gerrit.cloudera.org:8080/#/c/18134/14/be/src/udf/udf.cc@112 PS14, Line 112: user_string_ Just to learn something new: what was the problem with return ""? Also, I think that returning std::string() would be nicer. http://gerrit.cloudera.org:8080/#/c/18134/14/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: http://gerrit.cloudera.org:8080/#/c/18134/14/be/src/util/parquet-reader.cc@225 PS14, Line 225: an nit: a -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 14 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Sep 2022 16:03:19 +0000 Gerrit-HasComments: Yes
