Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 )
Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. ...................................................................... Patch Set 3: (16 comments) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java: http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/AlterTableExecuteRollbackStmt.java@43 PS3, Line 43: TAlterTableExecuteRollbackParams executeParams = new TAlterTableExecuteRollbackParams(); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/RollbackSpec.java File fe/src/main/java/org/apache/impala/analysis/RollbackSpec.java: http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/RollbackSpec.java@41 PS3, Line 41: case TIME: analyzeTimeBased(analyzer, "EXECUTE ROLLBACK(<expression>):"); break; // FIXME how to pass other paren line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/RollbackSpec.java@42 PS3, Line 42: case VERSION: analyzeVersionBased(analyzer, "EXECUTE ROLLBACK(<expression>):"); break; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/SnapshotSpec.java File fe/src/main/java/org/apache/impala/analysis/SnapshotSpec.java: http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/SnapshotSpec.java@58 PS3, Line 58: protected void analyzeTimeBased(Analyzer analyzer, String systemTimeSql) throws AnalysisException { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/analysis/SnapshotSpec.java@94 PS3, Line 94: protected void analyzeVersionBased(Analyzer analyzer, String versionSql) throws AnalysisException { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@199 PS3, Line 199: LOG.info(MessageFormat.format("Execute rollback kind={0} snapshotId={1} timestamp={2}", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@211 PS3, Line 211: LOG.debug(MessageFormat.format("Trying to rollback iceberg table to snapshot id {0}", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py File tests/common/iceberg_test_suite.py: http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@44 PS3, Line 44: i flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@48 PS3, Line 48: u flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@49 PS3, Line 49: n flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@56 PS3, Line 56: s flake8: E501 line too long (106 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@58 PS3, Line 58: D flake8: E501 line too long (107 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@59 PS3, Line 59: O flake8: E501 line too long (102 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@71 PS3, Line 71: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@71 PS3, Line 71: assert len(rows.data) == expected_result_size, """got unexpected number of line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19002/3/tests/common/iceberg_test_suite.py@117 PS3, Line 117: ( flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/19002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic74913d3b81103949ffb5eef7cc936303494f8b9 Gerrit-Change-Number: 19002 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 17 Sep 2022 00:38:27 +0000 Gerrit-HasComments: Yes
