Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18939 )
Change subject: IMPALA-10262: RPM/DEB Packaging Support ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/18939/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18939/4//COMMIT_MSG@20 PS4, Line 20: on a CDP cluster Is there restriction for CDP version? Could we upgrade or downgrade Impala package if there is old version of Impala package installed on the CDP cluster? If yes, old package will be overwrote or removed? http://gerrit.cloudera.org:8080/#/c/18939/4/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/4/CMakeLists.txt@596 PS4, Line 596: endif() Should we print error message if os is not matching with redhat or ubuntu? http://gerrit.cloudera.org:8080/#/c/18939/4/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/4/be/CMakeLists.txt@662 PS4, Line 662: install(DIRECTORY ${LLVM_IR_OUTPUT_DIRECTORY} DESTINATION ${IMPALA_INSTALLDIR}/) Should we run 'install' only when BUILD_PACKAGES is on? http://gerrit.cloudera.org:8080/#/c/18939/4/be/src/service/CMakeLists.txt File be/src/service/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18939/4/be/src/service/CMakeLists.txt@117 PS4, Line 117: install(FILES ${STATESTORED_SYMLINK} DESTINATION ${IMPALA_INSTALLDIR}/bin) Should we run 'install' only when BUILD_PACKAGES is on? http://gerrit.cloudera.org:8080/#/c/18939/4/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/18939/4/bin/impala-config.sh@850 PS4, Line 850: export STRIP_DEPLOYMENT_IMPALAD=true should we strip binaries for state-stored and catalogd as well? -- To view, visit http://gerrit.cloudera.org:8080/18939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64419fd400fe8d233dac016b6306157fe9461d82 Gerrit-Change-Number: 18939 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Mon, 19 Sep 2022 08:00:47 +0000 Gerrit-HasComments: Yes
