Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18962 )
Change subject: IMPALA-11511: Add build options for reducing binary sizes ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/18962/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18962/1//COMMIT_MSG@9 PS1, Line 9: Impala's build produces has dozens of C++ binaries > "produces has" doesn't read right. Good point, fixed http://gerrit.cloudera.org:8080/#/c/18962/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18962/1/be/CMakeLists.txt@220 PS1, Line 220: SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g1") > Will this end up adding it in Release mode? Is the next line sufficient? This line will add it for any type of build and I have verified that release works. The next line about CMAKE_CXX_FLAGS_DEBUG only really matters for CMAKE_BUILD_TYPE=Debug. Reworked the comment for CMAKE_CXX_FLAGS_DEBUG. The general problem is that CMAKE_BUILD_TYPE=Debug adds a "-g" after CMAKE_CXX_FLAGS, which overrides our "-g1". CMAKE_BUILD_TYPE=Release and others do not include a "-g", so they don't need a similar setting. http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py@297 PS1, Line 297: args = [dump_syms, decompressed_binary] : if objcopy_retcode != 0: > Should we check objcopy_retcode before calling dump_syms If objcopy fails, then dump_syms is unlikely to work, so we could just fail immediately. Instead, what I implemented here is to ignore the objcopy failure and then try to run dump_syms on the original executable rather than the copy. I'm not sure if this is the right answer, but it means that we always try to run dump_syms and get its error message. -- To view, visit http://gerrit.cloudera.org:8080/18962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04a20258a86053d8f3972b9c7c81cd5bec1bbb66 Gerrit-Change-Number: 18962 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 19 Sep 2022 22:45:55 +0000 Gerrit-HasComments: Yes
