Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 )
Change subject: IMPALA-11583: Use Iceberg API to update stats ...................................................................... Patch Set 6: (3 comments) Thanks for the comments. http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@77 PS4, Line 77: '','numRows ','2 ' > I am not sure which operation sets this property - can you unset it before Added UNSET. Also opened IMPALA-11597. http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@86 PS4, Line 86: show column stats ice_alltypes; : ---- RESULTS > Shouldn't we deny this operation, or at least return a warning? Users can set numRows for non-HMS integrated Iceberg tables. I could also add this check probably to https://github.com/apache/impala/blob/cff286e7512e9d1e2ff2b4ea033d3e575f54b353/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java#L153 But there is no complete list of Iceberg-managed table properties, so we will run into this repeatedly. http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@111 PS4, Line 111: 'p_d > Can you also add a drop stats statement? Done -- To view, visit http://gerrit.cloudera.org:8080/18995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b6e0a5a65e18e5aaf2a007ec0242b28e0fed92 Gerrit-Change-Number: 18995 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Sep 2022 15:58:33 +0000 Gerrit-HasComments: Yes
