Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19028 )
Change subject: [IMPALA-11527] UDTF pseudo code ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exec/transform-eval-node.h File be/src/exec/transform-eval-node.h: http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exec/transform-eval-node.h@22 PS1, Line 22: curr_user_status_ = reinterpret_cast<StringVal*>(expr_perm_pool_->Allocate(sizeof(StringVal))); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exec/transform-eval-node.h@30 PS1, Line 30: // Invoke TransformFnEvaluator Finalize function to set result_tuples_ for each partition line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exec/transform-eval-node.h@61 PS1, Line 61: // Handle each input RowBatch, when result_tuples_ is up to batch_size(), output result_tuples_. line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exec/transform-eval-node.h@80 PS1, Line 80: // Set result_tuples_ to output row_batch, this can output mutiple rows for one input row. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exprs/transform-fn-evalutor.h File be/src/exprs/transform-fn-evalutor.h: http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exprs/transform-fn-evalutor.h@69 PS1, Line 69: AnyValUtil::SetAnyVal(src_slot, transform_fn_.GetChild(i)->type(), staging_input_vals_[i]); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exprs/transform-fn.h File be/src/exprs/transform-fn.h: http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exprs/transform-fn.h@46 PS1, Line 46: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/exprs/transform-fn.h@53 PS1, Line 53: transform_fn_thrift.finalize_fn_symbol, &finalize_fn_, &cache_entry_); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udf-internal.h File be/src/udf/udf-internal.h: http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udf-internal.h@292 PS1, Line 292: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc File be/src/udf/udt-sample.cc: http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc@37 PS1, Line 37: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc@46 PS1, Line 46: void TransformUpdate(FunctionContext* context, const BigIntVal& total_step, const TimestampVal& time, const BigIntVal& step_info, StringVal* val) { line too long (147 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc@48 PS1, Line 48: FunnelConvertContext* funnelConvertContext = reinterpret_cast<FunnelConvertContext*>(val->ptr); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc@49 PS1, Line 49: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19028/1/be/src/udf/udt-sample.cc@55 PS1, Line 55: FunnelConvertContext* funnelConvertContext = reinterpret_cast<FunnelConvertContext*>(val.ptr); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52557f88149b689f400a01ca654ef9affae4df98 Gerrit-Change-Number: 19028 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Sep 2022 06:26:46 +0000 Gerrit-HasComments: Yes
