Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19028 )

Change subject: IMPALA-11527 UDTF pseudo code
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19028/6/be/src/exprs/transform-fn-evalutor.h
File be/src/exprs/transform-fn-evalutor.h:

http://gerrit.cloudera.org:8080/#/c/19028/6/be/src/exprs/transform-fn-evalutor.h@146
PS6, Line 146:     
reinterpret_cast<FinalizeFn>(transform_fn_.finalize_fn())(transform_fn_ctx_.get(),
 *dst);
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19028/6/be/src/exprs/transform-fn.h
File be/src/exprs/transform-fn.h:

http://gerrit.cloudera.org:8080/#/c/19028/6/be/src/exprs/transform-fn.h@45
PS6, Line 45:     // UDTF input parameter.
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/19028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52557f88149b689f400a01ca654ef9affae4df98
Gerrit-Change-Number: 19028
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 10:30:34 +0000
Gerrit-HasComments: Yes

Reply via email to