Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18989 )
Change subject: IMPALA-11582: Implement table sampling for Iceberg tables ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Test failed because of TIMEZONE conversions of TIMESTAMPTZ columns. Carry +2. http://gerrit.cloudera.org:8080/#/c/18989/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-tablesample-v2.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-tablesample-v2.test: http://gerrit.cloudera.org:8080/#/c/18989/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-tablesample-v2.test@33 PS4, Line 33: select * from iceberg_v2_partitioned_position_deletes tablesample system(50) repeatable(1234); > Shouldn't we add an order by here, to avoid flakiness caused by race betwee If there is no order by, the result set order doesn't matter. -- To view, visit http://gerrit.cloudera.org:8080/18989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5de151747c0e9d9379a4051252175fccf42efd7d Gerrit-Change-Number: 18989 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Sep 2022 10:39:55 +0000 Gerrit-HasComments: Yes
