Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results ...................................................................... Patch Set 13: Code-Review+1 (2 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@476 PS12, Line 476: returnsAtMostOneRow > It's not excluded structs. I will optimize it in IMPALA-11613. Done. http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test File testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test: http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test@141 PS12, Line 141: # Select stmt > I will continue optimize result spooling in IMPALA-11613 and add tests to t Done -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 13 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Mon, 26 Sep 2022 12:40:25 +0000 Gerrit-HasComments: Yes
