Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: [WIP] IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Frontend.thrift@747 PS7, Line 747: The optional max_cpu_usage_limit to determine which executor group set to run for : // a query. Add the more detailed description for measuring this variable http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Query.thrift@872 PS7, Line 872: stimated cpu usage per instance in bytes Traditionally CPU usage is measured in time. Here we use computing/processing bytes to measure CPU usage. Variable name "cpu_usage_bytes" is not very clear for me. In future, we may consider CPU frequency. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 7 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 07:44:53 +0000 Gerrit-HasComments: Yes
