Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19049 )
Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@388 PS1, Line 388: "select (case when (1 = 1 and `t1`.`dt` = '2022-05-13') then '2022-05-13' end) d0 " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@390 PS1, Line 390: + "group by (case when (1 = 1 and `t1`.`dt` = '2022-05-13') then '2022-05-13' end) " line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@391 PS1, Line 391: + "order by (case when (1 = 1 and `t1`.`dt` = '2022-05-13') then '2022-05-13' end) " line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@393 PS1, Line 393: "SELECT (CASE WHEN (1 = 1 AND `t1`.`dt` = '2022-05-13') THEN '2022-05-13' END) d0 " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@395 PS1, Line 395: + "GROUP BY (CASE WHEN (1 = 1 AND `t1`.`dt` = '2022-05-13') THEN '2022-05-13' END) " line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@396 PS1, Line 396: + "ORDER BY (CASE WHEN (1 = 1 AND `t1`.`dt` = '2022-05-13') THEN '2022-05-13' END) " line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912 Gerrit-Change-Number: 19049 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <jhkc...@qq.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Sep 2022 03:14:31 +0000 Gerrit-HasComments: Yes
