Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 )
Change subject: IMPALA-11565: For alter table, add column operation is optimized ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18953/7/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java: http://gerrit.cloudera.org:8080/#/c/18953/7/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java@93 PS7, Line 93: if (!col.getType().equals(c.getType())) { IMHO, users are expected the query to get successfully executed when they add the `if not exists` clause in the `alter table` statements. It's better to remove this validation, just ignore the duplicated columns, and support `alter table ... add column if not exists ...` for HDFS/Kudu tables. -- To view, visit http://gerrit.cloudera.org:8080/18953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82590e5372e881f2e81d4ed3dd0d32a2d3ddb517 Gerrit-Change-Number: 18953 Gerrit-PatchSet: 7 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 28 Sep 2022 03:16:17 +0000 Gerrit-HasComments: Yes
