Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19051 )
Change subject: IMPALA-11621: Remove hiveserver2.pid when shutting down HiveServer2 ...................................................................... IMPALA-11621: Remove hiveserver2.pid when shutting down HiveServer2 In HIVE-22193, Hive added graceful shutdown for HiveServer2. This modified some of the startup scripts to maintain a pid file. On startup, it verified that the pid is not already running. Impala uses the hive startup script, but it kills HiveServer2 with testdata/bin/kill-java-service.sh. If the pid file outlives the process, then the OS may reuse the pid and this can cause problems on startup. This modifies testdata/bin/kill-hive-server.sh to remove the pid file. testdata/bin/kill-java-service.sh would fail if it did not kill HiveServer2, so it should be safe to remove the pid file after the kill-java-service.sh call. Testing: - Verified the hiveserver2.pid file is removed after shutting down. Change-Id: I813626d06829a86854c6d2c1715f0c5f5109836d Reviewed-on: http://gerrit.cloudera.org:8080/19051 Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> Tested-by: Joe McDonnell <joemcdonn...@cloudera.com> --- M testdata/bin/kill-hive-server.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I813626d06829a86854c6d2c1715f0c5f5109836d Gerrit-Change-Number: 19051 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
