Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 )
Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19052/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19052/1//COMMIT_MSG@16 PS1, Line 16: - Run existing test_load.py > I realized that replication cannot be used as a verification of insert even I see. Can we use the hive_client to fetch and verify the INSERT events directly? We use it to fetch the latest event id here: https://github.com/apache/impala/blob/68650057a163ac23e1ca85b7d9d8dbfd975a69ff/tests/util/event_processor_utils.py#L125 Probably we can use get_next_notification() to fetch the INSERT events. http://gerrit.cloudera.org:8080/#/c/19052/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19052/3/be/src/service/client-request-state.cc@2047 PS3, Line 2047: nit: 2 spaces indent here -- To view, visit http://gerrit.cloudera.org:8080/19052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1b470f40e0aaf891c9f3f327af393b2f9c74bc Gerrit-Change-Number: 19052 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:27:41 +0000 Gerrit-HasComments: Yes