Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 )
Change subject: IMPALA-10851: Codegen for structs ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/18526/12/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/18526/12/be/src/runtime/descriptors.cc@972 PS12, Line 972: case TYPE_ARRAY: // CollectionVal has same memory layout as StringVal. > My point in an earlier comment was that https://gerrit.cloudera.org/c/18736 You're right, I forgot to add it. Done in the new patch. Also added it in codegen-anyval.cc. http://gerrit.cloudera.org:8080/#/c/18526/10/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18526/10/tests/query_test/test_nested_types.py@143 PS10, Line 143: def test_struct_in_select_list(self, vector): > Reversing order seems fine, but I'd add a comment why. I'd also add the oth Done -- To view, visit http://gerrit.cloudera.org:8080/18526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:27:13 +0000 Gerrit-HasComments: Yes
