Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18953 )
Change subject: IMPALA-11565: Support IF NOT EXISTS in alter table add columns for kudu table ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/18953/8/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18953/8/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@508 PS8, Line 508: hasColumnsAd > nit: "hasColumnsAdded" might be better Done. http://gerrit.cloudera.org:8080/#/c/18953/8/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test: http://gerrit.cloudera.org:8080/#/c/18953/8/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@374 PS8, Line 374: ID, NAME, VALI, NEW_COL1, NEW_COL2, NEW_COL3, NEW_COL4, NEW_COL5 > Could you add some tests on DESCRIBE between these ALTER statements? Done. -- To view, visit http://gerrit.cloudera.org:8080/18953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82590e5372e881f2e81d4ed3dd0d32a2d3ddb517 Gerrit-Change-Number: 18953 Gerrit-PatchSet: 9 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 03:38:16 +0000 Gerrit-HasComments: Yes
