Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/18958 )
Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc@183 PS1, Line 183: if (result.rfind("#", 0) == 0) continue; > Hi all, what if line start with '\t#'? or even line is 'ZONE=UTC # some com I thnik this should be defined as the wrong way of writing, and this should be a small probability event. -- To view, visit http://gerrit.cloudera.org:8080/18958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458 Gerrit-Change-Number: 18958 Gerrit-PatchSet: 4 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 09:33:23 +0000 Gerrit-HasComments: Yes