Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19099 )
Change subject: IMPALA-9460: ADD PARTITION doesn't accept SET FORMAT ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/19099/3/common/thrift/JniCatalog.thrift@120 PS3, Line 120: ADD_PARTITION_SET_FILE_FORMAT = 22 > Just a suggestion, can we consider reusing TAlterTableType.ADD_PARTITION? I agree, if it is possible we should reuse the existing class. http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java: http://gerrit.cloudera.org:8080/#/c/19099/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionSetFileFormatStmt.java@66 PS3, Line 66: if (tbl instanceof FeKuduTable) { : throw new AnalysisException( : "ALTER TABLE SET FILEFORMAT is not supported " + "on Kudu tables: " : + tbl.getFullName()); : } : : if (tbl instanceof FeIcebergTable) { : throw new AnalysisException( : "ALTER TABLE SET FILEFORMAT is not supported " + "on Iceberg tables: " : + tbl.getFullName()); : } > This has been checked at https://github.com/apache/impala/blob/master/fe/sr Did you want to throw with a different message than in AlterTableAddPartitionStmt? I think the error message there is okay, we can consider this a case of ALTER TABLE ADD PARTITION. But if the purpose is to change the error message, we would have to catch the exception from super.analyze() first. http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/19099/3/tests/metadata/test_ddl.py@646 PS3, Line 646: # Add partition with different fileformat Can we validate that the new partition created really has the specified file type? As far as I know the default is Parquet, so we should check with another format to see if setting the file format has an effect. -- To view, visit http://gerrit.cloudera.org:8080/19099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f78cc3c7eba25383128cd8fd881dd41ddea8b69 Gerrit-Change-Number: 19099 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 09:01:25 +0000 Gerrit-HasComments: Yes
