Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 )
Change subject: IMPALA-11606: add 'untracked memory' metric. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19029/5/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/19029/5/be/src/runtime/mem-tracker.cc@56 PS5, Line 56: shared_ptr<MemTracker> mem_tracker_; I think you don’t need a smart pointer here. 'mem_tracker' does not need maintenance in this class -- To view, visit http://gerrit.cloudera.org:8080/19029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib16e00109d732f759c96c7a967eb1cc32124a03f Gerrit-Change-Number: 19029 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jian Zhang <zjsar...@gmail.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Mon, 10 Oct 2022 11:52:16 +0000 Gerrit-HasComments: Yes
