Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19118
Change subject: IMPALA-11645: Remove PrintThriftEnum functions in debug-utils.cc ...................................................................... IMPALA-11645: Remove PrintThriftEnum functions in debug-utils.cc Before IMPALA-5690 we implemented operator<< for Thrift enums in Impala code. These functions printed the names of the enums. Then we upgraded to Thrift 0.9.3, but that release included THRIFT-2067, which implemented operator<< for Thrift enums, but printed the number value of enums instead of their names. To preserve the old behaviour in Impala, we renamed our own implementations of operator<< to PrintThriftEnum, a function that we defined for each Thrift enum we used, and which returned a string with the names - not the numbers - of the enums. After upgrading Thrift to a version that included THRIFT-3921 (any version starting from 0.11.0), these PrintThriftEnum functions are no longer necessary as the operator<< provided by Thrift now prints the names of enums, which is the behaviour we want. This change removes all PrintThriftEnum functions. At the call sites where the result of the function call was inserted into a stream, now the enum is inserted directly (invoking the operator<< provided by Thrift). At the call sites where a string object is expected, we replaced the call to PrintThriftEnum with a call to a new function template, PrintValue(), which converts any object for which operator<< is defined to a string. Change-Id: Ie36f6f0f032f3f5c7596929a1eccb80ff16fcd83 --- M be/src/benchmarks/scheduler-benchmark.cc M be/src/exec/exec-node.cc M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/kudu/kudu-scanner.cc M be/src/exec/parquet/parquet-column-readers.cc M be/src/exec/parquet/parquet-metadata-utils.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/runtime/coordinator.cc M be/src/runtime/fragment-instance-state.cc M be/src/service/client-request-state.cc M be/src/service/impala-http-handler.cc M be/src/service/query-options.cc M be/src/util/collection-metrics.cc M be/src/util/debug-util.cc M be/src/util/debug-util.h M be/src/util/histogram-metric.cc M be/src/util/metrics.cc 17 files changed, 50 insertions(+), 113 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/19118/1 -- To view, visit http://gerrit.cloudera.org:8080/19118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie36f6f0f032f3f5c7596929a1eccb80ff16fcd83 Gerrit-Change-Number: 19118 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com>
