Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19081 )
Change subject: IMPALA-11562: (Addendum) Update core-site to include ofs impl ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19081/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19081/2//COMMIT_MSG@9 PS2, Line 9: Updates core-site to include the ofs implementation rather than o3fs. I : believe this still worked because both ofs and o3fs implementations live : in the same jar file, so including either statement results in both : classes loading. However we should use the correct statement to avoid : issues in the future. Nit: Let's rework the commit message a bit. 1. fs.AbstractFileSystem.o3fs.impl and fs.ofs.impl are separate configurations that specify separate classes. They are loaded separately from the class path depending on whether we are using o3fs or ofs, but they come from the same jar (I think). 2. Since we no longer support o3fs, we can drop fs.AbstractFileSystem.o3fs.impl, as it isn't needed. 3. Prior to this change, fs.ofs.impl is using the default value, which happens to be right. This explicitly sets the value for cleanliness. So, I think I would have the commit message focus on 2 and 3. -- To view, visit http://gerrit.cloudera.org:8080/19081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41cbc875bef29e730ee2afcbda42f07017119593 Gerrit-Change-Number: 19081 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <weic...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Oct 2022 21:06:20 +0000 Gerrit-HasComments: Yes
