Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19114 )
Change subject: IMPALA-11607: Support for TPC-H and TPC-DS test datasets stored as Iceberg tables ...................................................................... Patch Set 8: (3 comments) This will be really useful. Left some minor comments. http://gerrit.cloudera.org:8080/#/c/19114/8/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/19114/8/testdata/bin/generate-schema-statements.py@347 PS8, Line 347: columns_str = ',\n'.join(columns.split('\n')) : if is_iceberg_table(file_format): : columns_str = columns_str.strip().strip(',') nit: could you please add a comment for this? http://gerrit.cloudera.org:8080/#/c/19114/8/testdata/bin/generate-schema-statements.py@763 PS8, Line 763: do not support SMALLINT type neither TINYINT http://gerrit.cloudera.org:8080/#/c/19114/8/testdata/bin/generate-schema-statements.py@766 PS8, Line 766: columns = columns.split("primary key")[0] Does it always work correctly? E.g. what if PRIMARY KEY declaration is in the column spec, e.g.: i INT PRIMARY KEY, j INT, ... -- To view, visit http://gerrit.cloudera.org:8080/19114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8bbc5209e7e649f67a48144a2844b35d9f9c7f1 Gerrit-Change-Number: 19114 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Oct 2022 08:25:58 +0000 Gerrit-HasComments: Yes
