Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19162
Change subject: IMPALA-11669: Set TConfiguration during Thrift connection setup ...................................................................... IMPALA-11669: Set TConfiguration during Thrift connection setup THRIFT-5237 Implement MAX_MESSAGE_SIZE and consolidate limits into a TConfiguration class. The MAX_MESSAGE_SIZE default to 100MB. This patch adds backend flag 'thrift_rpc_max_message_size' to override the default MAX_MESSAGE_SIZE in TAcceptQueueServer::SetupConnection. We set higher default, 1GB, to minimize interruption on existing Impala workload. We should consider lowering this default once we ensure that all thrift rpc response can be made in batches, such as explained in IMPALA-11402. Testing: - Call 'checkReadBytesAvailable' to verify that it does not throw exception given default FLAGS_thrift_rpc_max_message_size. - Run and pass thrift-server-test - Manualy hack TAcceptQueueServer::SetupConnection to call 'checkReadBytesAvailable' with parameter exceeding FLAGS_thrift_rpc_max_message_size and confirm that all tests in thrift-server-test throw exception. Change-Id: I137683d43c72a34105fd7b32fea3a93532601ae3 --- M be/src/rpc/TAcceptQueueServer.cpp M be/src/rpc/thrift-util.cc M be/src/rpc/thrift-util.h 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/19162/1 -- To view, visit http://gerrit.cloudera.org:8080/19162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I137683d43c72a34105fd7b32fea3a93532601ae3 Gerrit-Change-Number: 19162 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
