Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19096 )
Change subject: IMPALA-11537: Query option validation numeric types ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc@393 PS2, Line 393: // min_buffer_size is greater than RuntimeFilterBank::MAX_BLOOM_FILTER_SIZE. line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc@395 PS2, Line 395: return Status(Substitute("$0 should not be less than $1 which is the minimum " line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc@397 PS2, Line 397: _TImpalaQueryOptions_VALUES_TO_NAMES.at(option), FLAGS_min_buffer_size)); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc@590 PS2, Line 590: decltype(mem_value.value)>(mem_value.value, 0, SPILLABLE_BUFFER_LIMIT); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/service/query-options.cc@606 PS2, Line 606: decltype(mem_value.value)>(mem_value.value, 0, SPILLABLE_BUFFER_LIMIT); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/util/parse-util.h File be/src/util/parse-util.h: http://gerrit.cloudera.org:8080/#/c/19096/2/be/src/util/parse-util.h@57 PS2, Line 57: static MemSpec ParseMemSpec(const std::string& mem_spec_str, int64_t relative_reference); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7757b52393c094d2c661918d73cbfad7214f855 Gerrit-Change-Number: 19096 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Oct 2022 09:26:31 +0000 Gerrit-HasComments: Yes
