Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19055 )
Change subject: IMPALA-3119: DDL support for bucketed tables ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/19055/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19055/10//COMMIT_MSG@29 PS10, Line 29: > I see. Previously, CLUSTERED is identified as an IDENTIFIER. Now we define Wow, I was puzzled for a long time, thanks very much. http://gerrit.cloudera.org:8080/#/c/19055/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19055/11//COMMIT_MSG@19 PS11, Line 19: : > Is RANDOM actually useful in practise? Could you share some use cases? No, isn't. And the random ensures an even distribution of the data, but do not apply bucket_join. Don't worry about that. As communicated, only one hash algorithm is supported. http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup@1636 PS10, Line 1636: :} > I see. I checked the Hive parser and realized that in HiveQL the SortBy cla Yes, i think so. But it was originally intended that later versions would add sortby, because this increases the complexity of the implementation. This should be achieved in the future. http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup@1705 PS10, Line 1705: {: RESULT = TableDataLayout.createKuduPartitionedLayout(partition_params); :} > This hasn't been addressed. Done -- To view, visit http://gerrit.cloudera.org:8080/19055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919b4d4139bc3a7784fa6fdb6f064e25666d548e Gerrit-Change-Number: 19055 Gerrit-PatchSet: 13 Gerrit-Owner: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Baike Xia <xiaba...@163.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 27 Oct 2022 09:27:50 +0000 Gerrit-HasComments: Yes
