Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 )
Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables ...................................................................... Patch Set 7: (4 comments) A few nits http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@38 PS7, Line 38: * Helper class for storing Iceberg file descriptors. It stored data and delete files Nit: "stores" http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@39 PS7, Line 39: * separately, while also allowing to store file descriptors belonging to earlier Nit: while also storing file descriptors http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@93 PS7, Line 93: * Scanning Iceberg tables is not as simple as scanning legacy Hive tables. The Great comment http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/19043/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@26 PS7, Line 26: import org.apache.curator.shaded.com.google.common.collect.Iterators; Is this unused? -- To view, visit http://gerrit.cloudera.org:8080/19043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb883a28602bb68cf4f61e57cdd691605045ac5 Gerrit-Change-Number: 19043 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Oct 2022 16:51:34 +0000 Gerrit-HasComments: Yes
