Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19172 )
Change subject: IMPALA-7098: Re-enable tests under EC ...................................................................... Patch Set 5: Code-Review+1 (1 comment) All of this looks good to me. Just a small nit about the commit message. http://gerrit.cloudera.org:8080/#/c/19172/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19172/5//COMMIT_MSG@17 PS5, Line 17: Impala schedules work to executors based on blocks reported by HDFS, : which for EC actually represent block groups. So with default block : size, a file in EC has 1/3rd the number of schedulable blocks. Can you add a sentence about how this specifically results in Parquet lineitem having fewer files? Load single file to text = 6 blocks on non-EC, 2 block groups on EC => Parquet load has 3 files vs 2 files. -- To view, visit http://gerrit.cloudera.org:8080/19172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib452024993e35d5a8d2854c6b2085115b26e40df Gerrit-Change-Number: 19172 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 16:53:38 +0000 Gerrit-HasComments: Yes
