Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19165 )
Change subject: IMPALA-11683: Support Aliyun OSS File System ...................................................................... Patch Set 11: (5 comments) The patch looks good. Aside from some typos, just have one more question about the testing in the commit message. http://gerrit.cloudera.org:8080/#/c/19165/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19165/11//COMMIT_MSG@9 PS11, Line 9: Strorage nit. Storage http://gerrit.cloudera.org:8080/#/c/19165/11//COMMIT_MSG@9 PS11, Line 9: Oobject nit. Object http://gerrit.cloudera.org:8080/#/c/19165/11//COMMIT_MSG@14 PS11, Line 14: Mdddanual nit. Manual http://gerrit.cloudera.org:8080/#/c/19165/11//COMMIT_MSG@14 PS11, Line 14: Mdddanual ACID test verification. Could you elaborate a bit on how did you test on this feature? For example, in IMPALA-7712: Support Google Cloud Storage, https://gerrit.cloudera.org/#/c/17121/, Quanlong described in the commit message that how he prepared for the GCS test data before running core tests. I think this description is useful when the test needs some manual work. http://gerrit.cloudera.org:8080/#/c/19165/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19165/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@447 PS11, Line 447: a nit. an -- To view, visit http://gerrit.cloudera.org:8080/19165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I267e6531da58e3ac97029fea4c5e075724587910 Gerrit-Change-Number: 19165 Gerrit-PatchSet: 11 Gerrit-Owner: hezhenhua.hzh <hezhenhua....@alibaba-inc.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: hezhenhua.hzh <hezhenhua....@alibaba-inc.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 20:59:22 +0000 Gerrit-HasComments: Yes
