Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19096 )
Change subject: IMPALA-11537: Query option validation for numeric types ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/19096/8/be/src/service/query-option-parser.h File be/src/service/query-option-parser.h: http://gerrit.cloudera.org:8080/#/c/19096/8/be/src/service/query-option-parser.h@36 PS8, Line 36: template <typename T, typename = std::enable_if_t<std::is_arithmetic<T>::value, T>> > I agree that static_assert may be a better option but I'm not sure enabling What do you think about the other option? defining operator< for MemSpec, specialize std::to_string<MemSpec> and calling it for subtitute params, e.g: strings::Substitute( "$0 is not in range: [$1, $2]", std::to_string(original_value), std::to_string(lower), std::to_string(upper))); -- To view, visit http://gerrit.cloudera.org:8080/19096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7757b52393c094d2c661918d73cbfad7214f855 Gerrit-Change-Number: 19096 Gerrit-PatchSet: 8 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 10:24:51 +0000 Gerrit-HasComments: Yes
