Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19168 )
Change subject: IMPALA-11681: Set table stats for the Iceberg table by it's partition stats ...................................................................... Patch Set 6: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/19168/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19168/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@403 PS6, Line 403: rowBuilder.add(calculateNumRows(table)); : } : rowBuilder.add(calculateNumFiles(table)); : rowBuilder.addBytes(calculateFileSizeInBytes(table) Can't we just retrieve the stats from the 'table'? Since we are setting them in load()? http://gerrit.cloudera.org:8080/#/c/19168/6/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/19168/6/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@360 PS6, Line 360: setIcebergTableStats we probably also need to do this for LocalIcebergTable. -- To view, visit http://gerrit.cloudera.org:8080/19168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e92d3f25e2a57a64556249410d0af3522598c00 Gerrit-Change-Number: 19168 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Yingchun Lai <acelyc1112...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 17:31:19 +0000 Gerrit-HasComments: Yes
